Fix tray icon NRE: load BitmapImage from a file URI#15
Merged
Conversation
The unhandled-exception log (newly captured by PR #13) shows H.NotifyIcon's TaskbarIcon NREs deep inside ImageExtensions.ToStream(Uri) when IconSource is assigned. Reading the stack: H.NotifyIcon resolves ImageSource → BitmapImage.UriSource → file URI. Our BitmapImage was loaded via SetSourceAsync(InMemoryRandomAccessStream) — pixels present, UriSource null — and the library passes the null URI down its conversion chain, NREing on first method call. Persist the identicon PNG to %LOCALAPPDATA%\Snipdeck\tray-icon.png at init time and construct the BitmapImage with that URI. Disk cost is negligible (one ~1 KB file at app launch), the file location is stable across runs (deterministic identicon seed), and the shape matches what H.NotifyIcon's resolution path expects. HNotifyIconTrayService gains an IPathProvider dependency; both are already singletons in the DI container so no wiring change. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NullReferenceExceptionfromH.NotifyIcon.ImageExtensions.ToStream(Uri)thrown whenTaskbarIcon.IconSourceis assigned.BitmapImage.UriSource. We were loading the identicon viaSetSourceAsync(InMemoryRandomAccessStream)— pixels populated,UriSourcenull — so the library hit the null URI on first method call.%LOCALAPPDATA%\Snipdeck\tray-icon.pngat tray init and construct theBitmapImagewith that file URI.HNotifyIconTrayServicegains anIPathProviderdependency (both already singletons in DI).Notes
fix/crashlog-editorconfig) — merging PR Fix CrashLog editorconfig violations breaking the Windows build #14 first will shrink this PR's diff to just the tray fix.Test plan
unhandled.log; right-click → context menu shows Show/Exit; left-click brings the window forward.🤖 Generated with Claude Code